Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update on the treatment of logfile and log directory for the wiregrid kikusui agent #615

Merged
merged 2 commits into from
Feb 13, 2024
Merged

Update on the treatment of logfile and log directory for the wiregrid kikusui agent #615

merged 2 commits into from
Feb 13, 2024

Conversation

sadachi5
Copy link
Contributor

Description

Update about self.position_path, self.debug_log_path, and store_path.
The store_path is used in calibrate_wg(), which is a function only for a test to evaluate the feedback parameters (self.feedback_time and self.feedback_cut).

  • Remove unnecessary variable: self.position_path
  • Merge store_path in calibrate_wg() function and self.debug_log_path
  • Remove an argument of store_path in calibrate_wg()
  • Add if when using self.debug_log_path in stepwise_rotation() function.

Motivation and Context

These are modifications just to simplify the script and make it more reasonable.

How Has This Been Tested?

No

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@sadachi5
Copy link
Contributor Author

@BrianJKoopman
Could you approve this request?
Currently, in the stepwise_rotation() function, the debug_log_pathis tried to be opened but cannot be found.
So it makes an error for stepwise rotation.

@BrianJKoopman BrianJKoopman self-requested a review February 13, 2024 01:36
@BrianJKoopman
Copy link
Member

@BrianJKoopman Could you approve this request? Currently, in the stepwise_rotation() function, the debug_log_pathis tried to be opened but cannot be found. So it makes an error for stepwise rotation.

Apologies for the slow response. I'm not sure I follow your point about the current stepwise_rotation() function. You said this was untested, but I hope this resolves your issue. I'm going to go ahead and merge. If there are more tweaks, feel free to open another PR and request review.

@BrianJKoopman BrianJKoopman merged commit 4a1c6a7 into main Feb 13, 2024
7 checks passed
@BrianJKoopman BrianJKoopman deleted the sadachi5/wiregrid_kikusui_update branch February 13, 2024 01:41
hnakata-JP pushed a commit that referenced this pull request Apr 12, 2024
@sadachi5 @d-hoshino2626
Update on the treatment of logfile and log directory for the wiregrid…
9ee6ea0 
… kikusui agent (#615)

* update the log file treatment of the wiregrid_kikusui
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BrianJKoopman BrianJKoopman BrianJKoopman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sadachi5 @BrianJKoopman